]> dgit.raspbian.org Git - gnome-shell.git/commit
unlockDialog: Defend against absence of blur effect
authorZephaniah E. Loss-Cutler-Hull <warp@aehallh.com>
Sat, 15 Aug 2020 10:23:27 +0000 (03:23 -0700)
committerFlorian Müllner <fmuellner@gnome.org>
Mon, 24 Aug 2020 15:27:14 +0000 (17:27 +0200)
commit093603b35e085ffa88c49bae6a35fd93ce856e4d
tree6d3d92610c122a6d2a4d8ae038641e75c4439231
parentb436f3ebcb5ba8ffba54830c85c3f4cd35b9a7e5
unlockDialog: Defend against absence of blur effect

widget.get_effect(...) can return null while locking the screen, resulting
in a TypeError. In this situation the screen ends up black with a cursor
but never going to sleep, and moving the mouse brings the old screen
contents up but does not allow unlocking.

unlockDialog.js assumes that widget.get_effect will return non-null,
but other places such as getWindowDimmer in windowManager.js go out of
their way to be more careful.

[smcv: Add commit message, remove hard tabs, add missing semicolon]

Resolves: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3071
Bug-Debian: https://bugs.debian.org/968440
js/ui/unlockDialog.js